Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support outputting Clang compilation database #9

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

raphael-theriault-swi
Copy link
Member

See https://clang.llvm.org/docs/JSONCompilationDatabase.html for details about the format. Used by tools such as clangd to provide much better intellisense.

Also updates a bunch of dependencies.

@raphael-theriault-swi raphael-theriault-swi requested a review from a team September 25, 2023 17:35
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but curious because I'm still very lost--how is the compilation database generated ;) From quick read of the linked page it seems it's with a clang compiler flag?

@raphael-theriault-swi
Copy link
Member Author

It's generated by the script, from the flags pushed to dbFlags

@cheempz
Copy link
Contributor

cheempz commented Sep 27, 2023

It's generated by the script, from the flags pushed to dbFlags

Ah gotcha, so up to the user of this library, makes sense :)

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful comments @raphael-theriault-swi!

@raphael-theriault-swi raphael-theriault-swi merged commit 0e56ae6 into main Sep 27, 2023
1 check passed
@raphael-theriault-swi raphael-theriault-swi deleted the NH-61146 branch September 27, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants